Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include package name in share dir for presets #303

Merged
merged 1 commit into from
May 7, 2018

Conversation

alvarhansen
Copy link
Contributor

SettingsBuilder expects package name, this is currently missing from GitHub releases.

bundlePath + "../share/xcodegen/\(relativePath)",

Copy link
Collaborator

@toshi0383 toshi0383 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right. Thanks, good catch👍

@yonaskolb
Copy link
Owner

Thanks @alvarhansen! I'll re-upload the zip for the latest release then

@yonaskolb yonaskolb merged commit 800c46d into yonaskolb:master May 7, 2018
@yonaskolb
Copy link
Owner

Done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants