Fixed regression introduced in #289 #297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I guess that's the reason for yonaskolb#51 (comment), I haven't modified original pull request after new discoveries found in discussion yonaskolb#283 (primarily - that it is not Xcode 9.3 issue, but issue caused by Xcode and CLT installed in the same time). This patch modifies ENV only if CLT is installed. I've checked it against Xcode + CLT and it worked fine, it'll be great if someone can confirm that this one works on Xcode only system. You can do that by running `brew edit xcodegen` and after patching `brew reinstall xcodegen`
yonaskolb
approved these changes
Apr 14, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I guess that's the reason for
#51 (comment),
I haven't modified original pull request after new discoveries found in
discussion #283 (primarily - that it is not Xcode 9.3 issue, but issue
caused by Xcode and CLT installed in the same time).
This patch modifies ENV only if CLT is installed.
I've checked it against Xcode + CLT and it worked fine, it'll be great
if someone can confirm that this one works on Xcode only system. You
can do that by running
brew edit xcodegenand after patchingbrew reinstall xcodegen