-
Notifications
You must be signed in to change notification settings - Fork 821
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow lookup template attributes from globalTemplateAttributes #1400
base: master
Are you sure you want to change the base?
Conversation
@yonaskolb @brentleyjones Please help me review this PR |
@yonaskolb Please help me review this PR. Thanks |
I can see the utility in this @vikage. Got a few notes:
|
If you are agree with this feature, I will implement an example and some unit tests |
Yes happy for you to move it forward, with the ability to reference these values anywhere and not just within templates |
@yonaskolb I added unit test and example. Please help me review. |
@yonaskolb Please help me take a look |
@yonaskolb Please review, thanks |
This PR allow xcodegen to lookup template attributes from
globalTemplateAttributes
spec to share attributes accross all yaml files.For example here, we have a shared today-extension-target.yml between multi project specs: legacy-project.yml and new-project.yml
We need to configure different config files between legacy and old. With this PR we just declare a
version
attribute from project spec andtoday-extension-target.yml
can access itExample
today-extension-target.yml
legacy-project.yml
new-project.yml