Added fixes to better support packages with multiple origins and multiple executables #170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acecilia
force-pushed
the
package_list_fix
branch
2 times, most recently
from
bfb781d
to
11d701e
Compare
acecilia
changed the title
acecilia
force-pushed
the
package_list_fix
branch
3 times, most recently
from
406b5a7
to
11d6aa4
Compare
yonaskolb
reviewed
Apr 13, 2020
acecilia
added a commit
to acecilia/Mint
that referenced
this pull request
Apr 13, 2020
…rt when a package with the same name is installed from different origins (for example: yonaskolb/xcodegen and acecilia/xcodegen). [yonaskolb#170](yonaskolb#170) @acecilia - Rewrite the `list` option, to better support when a package produces multiple executables. [yonaskolb#170](yonaskolb#170) @acecilia - Rewrite and fix the `uninstall` option: previously, the name for the symlink to remove was calculated using the package name passed from command line, which could be partial (for example `simple` instead of `simplepackage`), resulting on the symlink not being removed. [yonaskolb#170](yonaskolb#170) @acecilia
acecilia
force-pushed
the
package_list_fix
branch
from
11d6aa4
to
aa990eb
Compare
acecilia
added a commit
to acecilia/Mint
that referenced
this pull request
Apr 13, 2020
…rt when a package with the same name is installed from different origins (for example: yonaskolb/xcodegen and acecilia/xcodegen). [yonaskolb#170](yonaskolb#170) @acecilia - Rewrite the `list` option, to better support when a package produces multiple executables. [yonaskolb#170](yonaskolb#170) @acecilia - Rewrite and fix the `uninstall` option: previously, the name for the symlink to remove was calculated using the package name passed from command line, which could be partial (for example `simple` instead of `simplepackage`), resulting on the symlink not being removed. [yonaskolb#170](yonaskolb#170) @acecilia
acecilia
force-pushed
the
package_list_fix
branch
from
aa990eb
to
34dda21
Compare
…rt when a package with the same name is installed from different origins (for example: yonaskolb/xcodegen and acecilia/xcodegen). [yonaskolb#170](yonaskolb#170) @acecilia - Rewrite the `list` option, to better support when a package produces multiple executables. [yonaskolb#170](yonaskolb#170) @acecilia - Rewrite and fix the `uninstall` option: previously, the name for the symlink to remove was calculated using the package name passed from command line, which could be partial (for example `simple` instead of `simplepackage`), resulting on the symlink not being removed. [yonaskolb#170](yonaskolb#170) @acecilia
acecilia
force-pushed
the
package_list_fix
branch
from
34dda21
to
2f4b8f6
Compare
acecilia
commented
Apr 13, 2020
| XCTAssertEqual(cache.list, """ | ||
| SimplePackage (https://github.com/yonaskolb/SimplePackage.git) | ||
| - 4.0.0 | ||
| SimplePackage (https://github.com/acecilia/SimplePackage.git) |
There was a problem hiding this comment.
If you have other account you prefer to rely on, instead of mine, I can change this
There was a problem hiding this comment.
Totally fine, if it sticks around 👍
yonaskolb
approved these changes
Apr 13, 2020
This was referenced Apr 13, 2020
discoverilla
added a commit
to discoverilla/Mint
that referenced
this pull request
Jun 10, 2022
…rt when a package with the same name is installed from different origins (for example: yonaskolb/xcodegen and acecilia/xcodegen). [#170](yonaskolb/Mint#170) @acecilia (#170) - Rewrite the `list` option, to better support when a package produces multiple executables. [#170](yonaskolb/Mint#170) @acecilia - Rewrite and fix the `uninstall` option: previously, the name for the symlink to remove was calculated using the package name passed from command line, which could be partial (for example `simple` instead of `simplepackage`), resulting on the symlink not being removed. [#170](yonaskolb/Mint#170) @acecilia
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added fixes to cover the following two scenarios:
1- When a package with the same name is installed from different origins. For example:
yonaskolb/xcodegenandacecilia/xcodegen.2- When a package produces multiple executables.
The main additions of this PR are:
listoption.runoption, so it asks for which package to run when multiple origins are detected, instead of just running the first match.uninstalloption, which includes the following fix: previously, the name for the symlink to remove was calculated using the passed package name, which could be partial (for examplesampleinstead ofsamplepackage), resulting on the symlink not being removed. Also added tests