Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove No pitch accent data from pitch handlebars #982

Merged
merged 4 commits into from
May 21, 2024
Merged

Remove No pitch accent data from pitch handlebars #982

merged 4 commits into from
May 21, 2024

Conversation

Kuuuube
Copy link
Member

@Kuuuube Kuuuube commented May 20, 2024 •
edited
Loading

Currently when pitch accent data is not found the handlebars report No pitch accent data. This is unnecessary.

@Kuuuube Kuuuube added kind/enhancement The issue or PR is a new feature or request area/anki The issue or PR is related to Anki integration labels May 20, 2024
@Kuuuube Kuuuube requested a review from a team as a code owner May 20, 2024 21:09
jamesmaa
jamesmaa approved these changes May 21, 2024
View reviewed changes
Copy link
Collaborator

@jamesmaa jamesmaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to update

@Kuuuube
Copy link
Member Author

Kuuuube commented May 21, 2024

Should be good.

@jamesmaa jamesmaa added this pull request to the merge queue May 21, 2024
Merged via the queue into yomidevs:master with commit 6998ebe May 21, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamesmaa jamesmaa jamesmaa approved these changes

Assignees
No one assigned
Labels
area/anki The issue or PR is related to Anki integration kind/enhancement The issue or PR is a new feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Kuuuube @jamesmaa