Fix -ge and add -garu transforms #952
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StefanVukovic99
approved these changes
May 16, 2024
Kuuuube
added
kind/bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #73
Source for げ inflection: https://ja.wiktionary.org/wiki/%E3%81%92
Source for がる inflection: https://ja.wiktionary.org/wiki/%E3%81%8C%E3%82%8B#%E6%8E%A5%E5%B0%BE%E8%BE%9E
-げ can be attached to the stem of 形容詞, and it is not needed for it to end in しい.
Since infinite cycle check has been implemented, かわいげ will now work.
As for words like よさげ, -げ works as a suffix to a noun. Since よさ can already be deinflected back to よい, I did not add this. If I do, -そう would need the same treatment, which is unnecessary.