Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add glossary-first handlebars #921

Merged
merged 4 commits into from
May 13, 2024
Merged

Add glossary-first handlebars #921

merged 4 commits into from
May 13, 2024

Conversation

Kuuuube
Copy link
Member

@Kuuuube Kuuuube commented May 12, 2024

Fixes #782

@Kuuuube Kuuuube added kind/enhancement The issue or PR is a new feature or request area/anki The issue or PR is related to Anki integration labels May 12, 2024
@Kuuuube Kuuuube requested a review from a team as a code owner May 12, 2024 13:56
@github-actions GitHub Actions
Copy link

github-actions bot commented May 12, 2024 •
edited
Loading

✔️ No visual differences introduced by this PR.

View Playwright Report (note: open the "playwright-report" artifact)

jamesmaa
jamesmaa reviewed May 12, 2024
View reviewed changes
Copy link
Collaborator

@jamesmaa jamesmaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's documentation you need to write tied to the help button I believe

@Kuuuube
Copy link
Member Author

Kuuuube commented May 12, 2024

There's documentation you need to write tied to the help button I believe

Added that.

@jamesmaa jamesmaa added this pull request to the merge queue May 13, 2024
Merged via the queue into yomidevs:master with commit 8139046 May 13, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamesmaa jamesmaa jamesmaa approved these changes

Assignees
No one assigned
Labels
area/anki The issue or PR is related to Anki integration kind/enhancement The issue or PR is a new feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

First dictionary only handlebar
2 participants
@Kuuuube @jamesmaa