forked from FooSoft/yomichan
-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add profile switching keyboard shortcuts #832
Merged
jamesmaa
merged 10 commits into
yomidevs:master
from
StefanVukovic99:816-profile-switch-shortcut
Apr 22, 2024
Merged
add profile switching keyboard shortcuts #832
jamesmaa
merged 10 commits into
yomidevs:master
from
StefanVukovic99:816-profile-switch-shortcut
Apr 22, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✔️ No visual differences introduced by this PR. View Playwright Report (note: open the "playwright-report" artifact) |
Kuuuube
added
kind/enhancement
The issue or PR is a new feature or request
area/ui-ux
The issue or PR is related to UI/UX/Design
labels
Apr 16, 2024
StefanVukovic99
changed the title
add profile switching
add profile switching keyboard shortcuts
Apr 18, 2024
jamesmaa
previously approved these changes
Apr 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Logic seems sound. Just not sure if we're picking the best hotkeys. Maybe it doesn't matter?
Conflict |
* duplicate behavior dropdown * allow duplicate for existing users * Update docs/anki-integration.md Co-authored-by: James Maa <[email protected]> Signed-off-by: StefanVukovic99 <[email protected]> * Update docs/anki-integration.md Co-authored-by: James Maa <[email protected]> Signed-off-by: StefanVukovic99 <[email protected]> * Update docs/anki-integration.md Co-authored-by: James Maa <[email protected]> Signed-off-by: StefanVukovic99 <[email protected]> * remove suggestion comment --------- Signed-off-by: StefanVukovic99 <[email protected]> Co-authored-by: James Maa <[email protected]>
jamesmaa
approved these changes
Apr 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/ui-ux
The issue or PR is related to UI/UX/Design
kind/enhancement
The issue or PR is a new feature or request
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #816