Fix leaking memory due to not improper cleanup of references to detached nodes

[Kuuuube]

Might fix #922, #836, #1480

I can't say for certain this is all of the issue but I wasn't able to find anything else in my testing.

[djahandarie]

Nice! Just curious, how did you discover these? It'd be nice if we had some visualization for the size of "state" like this over time faceted by variable name but seems like a hard problem in the abstract

[Kuuuube]

Nice! Just curious, how did you discover these? It'd be nice if we had some visualization for the size of "state" like this over time faceted by variable name but seems like a hard problem in the abstract

To see the detached elements: pull up the search page > F12 > Memory > Profiles > Detached elements > Start

To figure out what is causing them I just checked anywhere that could reference any of the detached elements it found and commented stuff out until there were no detached elements. Went back and uncommented stuff until it broke again. Then drilled down through whatever methods were being called commenting stuff out and testing until I finally got whatever sorted out.

This took hours.

[AdriGrana]

Wow that's some really good news! I shall try it and report back. Thanks a lot for the good work as always.