Fix firefox not showing Frequency Count when clicking on freq dict tag #1644
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kuuuube
added
kind/bug
jamesmaa
approved these changes
Dec 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to Firefox not allowing click events to fire for elements that are not visible, this wasn't working.
For freq tags there are two
tag-labelelements at different spots in the hierarchy where events are attached. One is visible, one is hidden. The parent element of these contains the tag details data. Firefox gets the one which is visible and fails to find the correct tag details to display in the notification. For whatever insane reason, Chromium does send through click events on invisible elements so it ends up getting the othertag-labelelement which did have the frequency count data on it. I'm also not sure why we have two tag labels to begin with and why theres one that is hidden but I'm not going to dig into that here.This PR just makes it so the data appears in both places.