Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When no dictionary is enabled, update preview after enable dictionary #1232

Merged
merged 5 commits into from
Jul 16, 2024
Merged

When no dictionary is enabled, update preview after enable dictionary #1232

merged 5 commits into from
Jul 16, 2024

Conversation

khaitruong922
Copy link

Fixes #1219

@khaitruong922 khaitruong922 requested a review from a team as a code owner July 16, 2024 14:51
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 16, 2024 •
edited
Loading

⚠️ Visual differences introduced by this PR; please validate if they are desirable.

View Playwright Report (note: open the "playwright-report" artifact)

@jamesmaa jamesmaa added this pull request to the merge queue Jul 16, 2024
Merged via the queue into yomidevs:master with commit 22da9df Jul 16, 2024
10 checks passed
@khaitruong922 khaitruong922 deleted the preview-not-update branch July 16, 2024 17:16
@Kuuuube Kuuuube added kind/bug The issue or PR is regarding a bug area/ui-ux The issue or PR is related to UI/UX/Design labels Jul 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamesmaa jamesmaa jamesmaa approved these changes

Assignees
No one assigned
Labels
area/ui-ux The issue or PR is related to UI/UX/Design kind/bug The issue or PR is regarding a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Popup preview is not updated if no dictionary is enabled when open the settings page
3 participants
@khaitruong922 @jamesmaa @Kuuuube