Set overscroll to contain for popup #1155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kuuuube
added
kind/enhancement
jamesmaa
approved these changes
Jun 30, 2024
This was referenced Jul 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1154
When the popup is scrolled to the very bottom and you continue to scroll this is overscroll. The default overscroll behavior is to start scrolling the parent scrollbar (in this case the parent page outside the popup) after the focused scroll element is at the bottom.
For the yomitan popup this doesn't make sense. Setting it to contain makes it so overscroll will do nothing and not propogate to the parent page.
(This change doesn't actually limit itself to the popup but all of our scrollable settings modals already use
overscroll: containanyways so theres no conflict)