Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Snow Legions will now properly infect dead mobs + New snow legion regenerative cores #22715

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

N3D6
Copy link
Contributor

@N3D6 N3D6 commented Oct 14, 2024

Document the changes in your pull request

Finally makes snow legions actually turn dead people into snow legions.

Adds new snow legion regenerative cores that look like glowing snowballs.

Why is this good for the game?

makes snow legions less buggy and less lazy with new regeneration cores

Testing

Tested and functional, works as intended.

Spriting

Inert snow legion cores re-use the snowball sprite

Stabilized snow legion core

Screen.Recording.2024-10-13.202621.mp4

Unstabilized core

Screen.Recording.2024-10-13.202652.mp4

Wiki Documentation

All of IceMeta needs a wiki page

Changelog

🆑
bugfix: snow legions now properly infect dead mobs
imageadd: new snow legion core sprites
rscadd: snow legion regenerative cores
/:cl:

@N3D6 N3D6 requested a review from a team as a code owner October 14, 2024 00:29
@Yogbot-13 Yogbot-13 added Feature This adds new content to the game Fix This fixes an issue. Please link issues in fix PRs Sprites This PR has spriting changes labels Oct 14, 2024
Copy link
Contributor

@ToasterBiome ToasterBiome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not good code
I have the next few days off so i can show you how to utilize types with this

@N3D6
Copy link
Contributor Author

N3D6 commented Oct 14, 2024

This is not good code I have the next few days off so i can show you how to utilize types with this

yeah I’ll improve it I just have no clue at all how to do so on my own

@N3D6
Copy link
Contributor Author

N3D6 commented Oct 18, 2024

all shitcode should be fixed here now

@ToasterBiome
Copy link
Contributor

This is partially my code now so I cant review it :^)

@ToasterBiome ToasterBiome requested a review from a team October 18, 2024 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature This adds new content to the game Fix This fixes an issue. Please link issues in fix PRs Sprites This PR has spriting changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants