-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve Docker setup #655
base: master
Are you sure you want to change the base?
Improve Docker setup #655
Conversation
Opinions? Not sure if it's still relevant. Some parts are, some aren't. |
Feel free to take this PR over :) |
Need testing |
@psyray I'll test this after I heard your opinion about it. In my opinion, it's a good change, because it modernises the Docker process/workflow. @n-thumann Could you please solve the conflicts and modernise it to today's date? Since your PR is from 2022. After that, I'll be happy to test this, and merge this into our project if the other maintainers agree as well. Thanks! |
I f you think it's good, it's good for me |
c85e704
to
018323c
Compare
Please note that I haven't used reNgine for a long time and won't be able to test the changes now or implement any additional changes. I did a quick rebase and resolved the conflicts though. For any additional change requests, don't hesitate to take over this PR and implement them yourself :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a small nitpicks and a comment. I'll test this later, thanks!
:: Show this help. | ||
if "%1" == "help" @echo Make application docker images and manage containers using docker-compose files only for windows. | ||
if "%1" == "help" @echo Make application docker images and manage containers using docker compose files only for windows. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if "%1" == "help" @echo Make application docker images and manage containers using docker compose files only for windows. | |
if "%1" == "help" @echo Make application Docker images and manage containers using Docker Compose files only for Windows. |
Small nit.
|
||
prune: ## Remove containers and delete volume data. | ||
@make stop && make rm && docker volume prune -f | ||
|
||
help: ## Show this help. | ||
@echo "Make application docker images and manage containers using docker-compose files." | ||
@echo "Make application docker images and manage containers using docker compose files." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@echo "Make application docker images and manage containers using docker compose files." | |
@echo "Make application Docker images and manage containers using Docker Compose files." |
@AnonymousWP is there any tests that was done since ? Maybe a next step would be to use docker compose v3 or draft a PR for it, apparently it's not too hard to port v2 to v3 from what I read from here : https://vsupalov.com/upgrade-docker-compose-file-version/ |
This PR introduces some improvements regarding the Docker setup.
I tried to run reNgine in a newly created VM and noticed a few things that would allow a user to get reNgine up and running much quicker, which are:
docker-compose
(v1): Since Docker Engine 20.10.13 the new Docker Compose v2 CLI is available by default (see https://docs.docker.com/engine/release-notes/#201013). It's was available in Docker Desktop much earlier and is default since 4.8.0. Hence there's no need for manually installingdocker-compose
(v1).docker-compose-plugin
is also installed automatically by get.docker.com.make build
is still possible of course.context
in build configurationnetworks
specificationI am running these changes on my local machine without any issues :)