Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: add language-server-bitbake as a dependence #178

Open
wants to merge 1 commit into
base: staging
Choose a base branch
from

Conversation

Freed-Wu
Copy link
Contributor

Decouple client and server

client/package.json Outdated Show resolved Hide resolved
client/package.json Outdated Show resolved Hide resolved
client/package.json Outdated Show resolved Hide resolved
@Freed-Wu Freed-Wu force-pushed the client branch 3 times, most recently from 3fdb269 to c8bb651 Compare March 18, 2024 16:06
@Freed-Wu
Copy link
Contributor Author

Can we add server/resources to repo, not download it every time? It is very slow for fetch-docs.sh.

resources.zip

@deribaucourt
Copy link
Member

Can we add server/resources to repo, not download it every time? It is very slow for fetch-docs.sh.

resources.zip

Adding a binary object is not a good git practice. We actually do that for the .wasm but I'm not a fan of it. I think the fetch time is not obnoxious in my developper experience or the CI, it's not as long as compiling or running tests. Also during development it must only be run once. What is your use case where you find it to be too slow?

@Freed-Wu
Copy link
Contributor Author

What is your use case where you find it to be too slow?

Perhaps due to my poor network? 😢

@Freed-Wu
Copy link
Contributor Author

Any other problems about this PR?

@deribaucourt
Copy link
Member

Any other problems about this PR?

The debug configurations must be updated (.vscode/launch.json & tasks.json).
Also when packaging, this will fetch the previous release of the server. So during a release cycle, we get a mismatching server/client.

Copy link
Member

@deribaucourt deribaucourt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Debug configurations and release need to be fixed

@Freed-Wu
Copy link
Contributor Author

Freed-Wu commented Apr 2, 2024

Debug configurations and release need to be fixed

I am not familiar with .vscode/*.json. Can you create another PR to update them?

@deribaucourt
Copy link
Member

Debug configurations and release need to be fixed

I am not familiar with .vscode/*.json. Can you create another PR to update them?

This is the tricky part... I think it requires a lot of thought and clever refactoring of the whole packaging system. Hence why I haven't touched it yet. It's not something I can prioritize right now. It's rather a nice to have and doesn't appear to be blocking for any feature or bug fix.

@Freed-Wu
Copy link
Contributor Author

Freed-Wu commented Apr 8, 2024

Rebased to HEAD and test passed. Can we merge this PR then see and fix any new problems?

@deribaucourt
Copy link
Member

Rebased to HEAD and test passed. Can we merge this PR then see and fix any new problems?

I can't merge a PR that breaks all our development tools. It would block all other developments and debugging.

@Freed-Wu
Copy link
Contributor Author

Freed-Wu commented Apr 8, 2024

This is the tricky part...

OK, let us wait the tricky part 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants