openssh: drop rejected patch fixed in 8.6p1 release

The rationale [1] is that C11 6.5.6.9 says: """ When two pointers are subtracted, both shall point to elements of the same array object, or one past the last element of the array object; the result is the difference of the subscripts of the two array elements. """ In these cases the objects are arrays of char so the result is defined, and we believe that the compiler incorrectly trapping on defined behaviour. I also found https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63303 ("Pointer subtraction is broken when using -fsanitize=undefined") which seems to support this position. [1] https://bugzilla.mindrot.org/show_bug.cgi?id=2608 (From OE-Core rev: ea9b6812e2e547767d430a05f4f9282f6988468a) Signed-off-by: Jose Quaresma <[email protected]> Signed-off-by: Richard Purdie <[email protected]> (cherry picked from commit cf193ea67ca852e76b19a7997b62f043b1bca8a1) Signed-off-by: Jose Quaresma <[email protected]> Signed-off-by: Steve Sakoman <[email protected]>
yoctoproject · Aug 1, 2024 · 73481ba · 73481ba
1 parent 27a526f
commit 73481ba
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 112 deletions.
diff --git a/...es-connectivity/openssh/openssh/fix-potential-signed-overflow-in-pointer-arithmatic.patch b/...es-connectivity/openssh/openssh/fix-potential-signed-overflow-in-pointer-arithmatic.patch
diff --git a/meta/recipes-connectivity/openssh/openssh_9.6p1.bb b/meta/recipes-connectivity/openssh/openssh_9.6p1.bb
@@ -22,7 +22,6 @@ SRC_URI = "http://ftp.openbsd.org/pub/OpenBSD/OpenSSH/portable/openssh-${PV}.tar
            file://sshdgenkeys.service \
            file://volatiles.99_sshd \
            file://run-ptest \
-           file://fix-potential-signed-overflow-in-pointer-arithmatic.patch \
            file://sshd_check_keys \
            file://add-test-support-for-busybox.patch \
            file://0001-regress-banner.sh-log-input-and-output-files-on-erro.patch \