Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add loaded asset extensions settings for layout loaders in unreal host #44

Conversation

moonyuet
Copy link
Member

Changelog Description

Resolve #6 in unreal

Additional info

we need to resolve the maya part too once the load layout json implemented in maya

Testing notes:

  1. Build Unreal Addon with this branch
  2. Set your preferred loaded extension in ayon+settings://unreal/loaded_assets_extension
    image
  3. Launch Unreal
  4. Ayon -> Load
  5. Click the memo icon in Load Layout(json)
    image
  6. Load your preferred loaded extension format (if you dont think the one you set in ayon server)
    image
  7. Click "ok"

@moonyuet moonyuet requested a review from LiborBatek August 14, 2024 07:23
@moonyuet moonyuet requested a review from antirotor August 14, 2024 07:23
@moonyuet moonyuet changed the title add loaded settings for layout loaders in unreal host add loaded asset extensions settings for layout loaders in unreal host Aug 14, 2024
Copy link
Member

@LiborBatek LiborBatek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even tho I am experiencing those settings and have them present/visible within Ayon Settings and also when using Loader actions (as right click menu entry) I wasnt able to load layout neither as Alembic nor FBX

Not sure whats the issue there but I have tried whatever could work but no luck...Im just getting empty UE level and sequence no matter if FBX or Alembic been set.

@moonyuet moonyuet requested a review from LiborBatek August 14, 2024 14:31
@moonyuet
Copy link
Member Author

Even tho I am experiencing those settings and have them present/visible within Ayon Settings and also when using Loader actions (as right click menu entry) I wasnt able to load layout neither as Alembic nor FBX

Not sure whats the issue there but I have tried whatever could work but no luck...Im just getting empty UE level and sequence no matter if FBX or Alembic been set.

Thanks for testing, it is mainly because the code doesn't get the fbx/abc loading asset data correctly. Can you please test it again by pulling the latest commit?

Copy link
Member

@LiborBatek LiborBatek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works for me, and if chosen FBX it uses such repre when Load Layout action used.

Also tested with ABC and works too.

LGTM

note: we are not able to load asset in 2 different representation (Abc / FBX) atm ...as when you try to do so, it will perform check if uasset present and skips it?? something for different PR I guess

for e.g. having already mech_warrior in version 03 and Alembic ....wont let you load the same but FBX repre as the uasset already exists

@moonyuet
Copy link
Member Author

It works for me, and if chosen FBX it uses such repre when Load Layout action used.

Also tested with ABC and works too.

LGTM

note: we are not able to load asset in 2 different representation (Abc / FBX) atm ...as when you try to do so, it will perform check if uasset present and skips it?? something for different PR I guess

Yes it can be different PR, we have the ticket to track and fix the issue: #42

@moonyuet moonyuet merged commit 593405e into develop Aug 19, 2024
1 check passed
@moonyuet moonyuet deleted the enhancement/AY-3895_Representation-type-priority-on-Layout-loading branch August 19, 2024 11:25
@antirotor antirotor added the type: enhancement Improvement of existing functionality or minor addition label Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement Improvement of existing functionality or minor addition
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unreal: Representation priority on Layout loading
3 participants