Checking on the folder entity if it is there. #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LiborBatek
approved these changes
Jul 5, 2024
BigRoy
reviewed
Jul 8, 2024
…here is folder entity
BigRoy
reviewed
Jul 8, 2024
BigRoy
reviewed
Jul 8, 2024
Co-authored-by: Roy Nieterau <[email protected]>
Co-authored-by: Roy Nieterau <[email protected]>
BigRoy
reviewed
Jul 8, 2024
Co-authored-by: Roy Nieterau <[email protected]>
BigRoy
approved these changes
Jul 8, 2024
There was a problem hiding this comment.
Didn't test but changes look good to me.
If I recall correctly from other addons @iLLiCiTiT I'm not sure about version bumping this addon now or whether that should be part of releases instead? (also the version numbers mismatching, one being -dev, etc seems fishy.
…der_entity attribute
|
Version bump should not happen! (and why is there different version in package.py and version.py?) |
iLLiCiTiT
reviewed
Jul 15, 2024
iLLiCiTiT
reviewed
Jul 15, 2024
Co-authored-by: Jakub Trllo <[email protected]>
Co-authored-by: Jakub Trllo <[email protected]>
antirotor
added
the
type: enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog Description
Make sure the code still workings with/without
folder_entity["id"]Resolve #12
Additional Info
Make sure you build the addon with this branch
Testing Notes