Fix use of stagingDir #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use stagingDir on instance only if it is explicitly set as custom, in other case fall back to old implementation which produces baking script next in `work/../renders`
stagingDir_is_custom is available only in 1.0.13
jakubjezek001
approved these changes
Jan 14, 2025
There was a problem hiding this comment.
Looking good, but I let @robin-ynput judge if this is a solid ground.
robin-ynput
approved these changes
Jan 14, 2025
There was a problem hiding this comment.
@kalisp I hope you don't mind me pushing on the top of you PR.
When testing these changes, I realized Nuke staging directory was not working as expected after ynput/ayon-core#1069, so I've added the necessary code changes.
Please note that it will also require this fix in ayon-core to behave properly: ynput/ayon-core#1084
|
Tested, works. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog Description
Use stagingDir on instance only if it is explicitly set as custom, in other case fall back to old implementation which produces baking script next in
work/../renders.Additional review information
This solves issue in
extract_review_intermediateswhen now there wasstagingDiron instance suddenly. This resulted in creation of baking script intempdirwhich got purged at the end of publishing viaClean Upplugin.This PR is variant of similar issue in Maya ynput/ayon-maya#212
Testing notes: