Improve applying render resolution and aspect ratio on render settings reset #75
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog Description
Fix pixel aspect ratio / device aspect ratio getting messed up for Arnold renderer on render settings reset.
Additionally:
Additional info
This fixes a bug when resetting render resolution for Arnold where on reset the pixel/device aspect ratio would be oddly set with a pixel aspect ratio that is not 1.0.
E.g. left is before, right is after resetting render settings without this PR
After this PR the pixel aspect ratio will now adhere to what is specified on the task entity.
This bug was only occurring if the current renderer render settings were reset for was actively Arnold (mtoa) renderer.
Testing notes:
Note that this is about Set Render Settings or the feature that it automatically does so on creating a render publish instance in the scene (enabled by default).