Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create ASS: Add more export options (AY-6100) #25

Merged

Conversation

BigRoy
Copy link
Contributor

@BigRoy BigRoy commented Jul 16, 2024

Changelog Description

Expose more settings to the Create Ass export, like file type specific options for creating compressed .ass.gz exports.

Additional info

New settings

ayon+settings://maya/create/CreateAss/maskImager    (default: false)
ayon+settings://maya/create/CreateAss/boundingBox    (default: true)
ayon+settings://maya/create/CreateAss/compressed    (default: false)

image

Also on instance:
image

Using the settings as defaults.

Question: Should I expose "Use Binary Encoding" ❓ 📔

The Ass file type specific options also expose a "Use Binary Encoding" option:

image

I did not expose it on the Creator because it already seemed tied to a class variable on the Extractor here. I wasn't entirely sure whether there was a reason for that - it did not seem to be exposed to settings. Looking at it again it seems that this is because it's overridden in code for the proxy exports

@m-u-r-p-h-y Do we want to expose that too?
- Also toggle-able on the instance?
- or should we keep the setting on the Extractor, also in settings hidden from the artists?

Improved validator

Also improved a validation report because I had no idea what it did when I hit the error - so I added some description to the report to be clearer for future me and other artists:

image

Testing notes:

  1. Upload new maya addon package
  2. Toggle settings should work
  3. Export settings should work
  4. Resulting publish should work and adhere to the instance settings
  5. Loading the published instances should work as intended.

Clickup AY-6100

@BigRoy BigRoy added the type: enhancement Improvement of existing functionality or minor addition label Jul 16, 2024
@BigRoy BigRoy changed the title Create ASS: Add more export options Create ASS: Add more export options (AY-6100) Jul 16, 2024
Copy link
Member

@moonyuet moonyuet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done simple test in Maya 2025
With compressed on, it will export .ass.gz
image
When compressed off, it will export .ass
image
Testing with other two new options and working smoothly

Copy link
Member

@m-u-r-p-h-y m-u-r-p-h-y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

setting the compress format works correctly

my question is why do we have this need to name things differently in every single place?
image

Mask Shape -> Export Shape -> Shape

can't we just match the options in Maya so it is clear what is what?

@BigRoy
Copy link
Contributor Author

BigRoy commented Jul 19, 2024

setting the compress format works correctly

my question is why do we have this need to name things differently in every single place? image

Mask Shape -> Export Shape -> Shape

can't we just match the options in Maya so it is clear what is what?

It's because we 'matched' what Arnold does. The actual flags in the arnold export commands name them "mask" whatever. That's where I suspect that originated from, they just don't show that in the labels.

I'll update the settings labels and then we're good?

BigRoy added 3 commits July 19, 2024 11:21
Kept the keys the same because that's what they are also actually in arnold for the arnold commands, etc. plus it allowed for better backwards compatibility of settings
@BigRoy
Copy link
Contributor Author

BigRoy commented Jul 19, 2024

I'll update the settings labels and then we're good?

Done with 252ba09

Note: You'll need to build and update the addon on the server to get the updated settings of course.

@BigRoy BigRoy requested a review from m-u-r-p-h-y July 19, 2024 09:25
@BigRoy
Copy link
Contributor Author

BigRoy commented Jul 23, 2024

@m-u-r-p-h-y can you confirm the latest changes make it work the way you want?

@BigRoy BigRoy self-assigned this Jul 24, 2024
Copy link
Member

@m-u-r-p-h-y m-u-r-p-h-y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@m-u-r-p-h-y can you confirm the latest changes make it work the way you want?

do not like the Export some1, Export some2, Export some3 but we probably can not design the publisher UI in a similar way to Maya.

the new defaults also match Maya so yes, good to go . . .

@BigRoy
Copy link
Contributor Author

BigRoy commented Jul 25, 2024

do not like the Export some1, Export some2, Export some3 but we probably can not design the publisher UI in a similar way to Maya.

@m-u-r-p-h-y only other thing I can get it to is this:

Alternative

image

As opposed to:

Current

image


Would you like me to push the changes so it looks like "Alternative" (first image)?

@m-u-r-p-h-y
Copy link
Member

Would you like me to push the changes so it looks like "Alternative" (first image)?

Alternative RULEZ!

@BigRoy BigRoy merged commit 3faee84 into ynput:develop Jul 26, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement Improvement of existing functionality or minor addition
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants