-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create ASS: Add more export options (AY-6100) #25
Create ASS: Add more export options (AY-6100) #25
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Kept the keys the same because that's what they are also actually in arnold for the arnold commands, etc. plus it allowed for better backwards compatibility of settings
…//github.com/BigRoy/ayon-maya into enhancement/maya_create_ass_add_more_options
Done with 252ba09 Note: You'll need to build and update the addon on the server to get the updated settings of course. |
@m-u-r-p-h-y can you confirm the latest changes make it work the way you want? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@m-u-r-p-h-y can you confirm the latest changes make it work the way you want?
do not like the Export some1, Export some2, Export some3 but we probably can not design the publisher UI in a similar way to Maya.
the new defaults also match Maya so yes, good to go . . .
@m-u-r-p-h-y only other thing I can get it to is this: Alternative As opposed to: Current Would you like me to push the changes so it looks like "Alternative" (first image)? |
Alternative RULEZ! |
…aya export dialog
…//github.com/BigRoy/ayon-maya into enhancement/maya_create_ass_add_more_options
Changelog Description
Expose more settings to the Create Ass export, like file type specific options for creating compressed
.ass.gz
exports.Additional info
New settings
Also on instance:
Using the settings as defaults.
Question: Should I expose "Use Binary Encoding" ❓ 📔
The Ass file type specific options also expose a "Use Binary Encoding" option:
I did not expose it on the Creator because it already seemed tied to a class variable on the Extractor here. I wasn't entirely sure whether there was a reason for that - it did not seem to be exposed to settings. Looking at it again it seems that this is because it's overridden in code for the proxy exports
@m-u-r-p-h-y Do we want to expose that too?
- Also toggle-able on the instance?
- or should we keep the setting on the Extractor, also in settings hidden from the artists?
Improved validator
Also improved a validation report because I had no idea what it did when I hit the error - so I added some description to the report to be clearer for future me and other artists:
Testing notes:
Clickup AY-6100