Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Load Layout from the json exported from maya layout should have correct transform #199

Merged
merged 3 commits into from
Dec 16, 2024
Merged

Load Layout from the json exported from maya layout should have correct transform #199

merged 3 commits into from
Dec 16, 2024

Conversation

moonyuet
Copy link
Member

@moonyuet moonyuet commented Dec 16, 2024 •
edited
Loading

Changelog Description

This PR is to fix the incorrect transformation being set across the asset when loading layout from the json exported by extract layout in maya.
Resolve: #200

Additional review information

n/a

Testing notes:

  1. Create Layout
  2. Extract Layout
  3. Load Layout
  4. All transforms should be correct.

@moonyuet moonyuet added the type: bug Something isn't working label Dec 16, 2024
@moonyuet moonyuet self-assigned this Dec 16, 2024
@moonyuet moonyuet added the sponsored This is directly sponsored by a client or community member label Dec 16, 2024
LiborBatek
LiborBatek requested changes Dec 16, 2024
View reviewed changes
Copy link
Member

@LiborBatek LiborBatek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did try multiple times and also with built package for maya addon but it doesnt work once loaded back into maya as JSON.

Assets having some Y axis offset as seen on the pic below (negative offset)

Screenshot 2024-12-16 121606

@moonyuet moonyuet requested a review from LiborBatek December 16, 2024 13:22
LiborBatek
LiborBatek approved these changes Dec 16, 2024
View reviewed changes
Copy link
Member

@LiborBatek LiborBatek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now all seems correct and with proper transforms. Been tested and compared to .ma layout repre. Also cherrypicked asset been compared and transforms matches 1:1

LGTM

image

@moonyuet moonyuet merged commit cb1c5d2 into develop Dec 16, 2024
1 check passed
@moonyuet moonyuet deleted the bugfix/AY-7267_Loading-Maya-JSON-Layout-to-Maya-fails branch December 16, 2024 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LiborBatek LiborBatek LiborBatek approved these changes

@antirotor antirotor Awaiting requested review from antirotor

Assignees

@moonyuet moonyuet

Labels
sponsored This is directly sponsored by a client or community member type: bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AY-7267_Loading Maya JSON Layout to Maya fails
2 participants
@moonyuet @LiborBatek