Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip invalid containers with a warning #179

Open
wants to merge 6 commits into
base: develop
Choose a base branch
from

Conversation

BigRoy
Copy link
Contributor

@BigRoy BigRoy commented Nov 14, 2024

Changelog Description

Skip invalid containers with a warning - instead of breaking publishi…ng, loader, inventory, etc.

Additional review information

This avoids similar issues as #178 does - but is a 'fix' that would avoid the issue being problematic in existing scenes (instead of just on containerise) or if the container breaks in any other way.

The most likely case for these containers to become invalid was the issue #178 solves by 'bundling' undo so that users can't undo "half of the container creation" deleting only a few of its attributes. However, users can still break things in magical ways, time has shown us.

It would now log e.g. this if the container is incomplete and incomplete containers are not listed in the scene inventory either, because well they are incomplete:

// Warning: ayon_maya : Container 'char_hero_pointcacheMain_01__pointcacheMain_CON' is missing required keys: ['loader', 'representation']

Testing notes:

  1. Load a few products
  2. In outliner, enable: Display > Ignore "Hidden in outliner"
  3. Select the containers
  4. Randomly delete attributes on these instances, like loader, representation, etc.

A warning should be logged if any of the required keys ends up missing. The required keys are considered to be ["id", "name", "namespace", "loader", "representation"]

@BigRoy BigRoy added type: enhancement Improvement of existing functionality or minor addition community Issues and PRs coming from the community members labels Nov 14, 2024
@BigRoy BigRoy self-assigned this Nov 14, 2024
Copy link
Member

@LiborBatek LiborBatek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well and when some attributes missing, it still publishes ok and just gives warning about some missing keys...LGTM

image

@BigRoy BigRoy requested a review from iLLiCiTiT December 30, 2024 12:23
@LiborBatek
Copy link
Member

@BigRoy should I also re-test it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community Issues and PRs coming from the community members type: enhancement Improvement of existing functionality or minor addition
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants