Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Maya USD: Do not error on context attribute value change #171

Conversation

BigRoy
Copy link
Contributor

@BigRoy BigRoy commented Nov 5, 2024

Changelog Description

Create Maya USD: Do not error on context attribute value change

Additional review information

Should fix error posted here

Works nicely, the only occasion which throw some traceback is when trying to switch settings for context and Validate outdated containers

Screenshot 2024-11-05 094409

resulting in

// Traceback (most recent call last):
//   File "C:\Work\REPO\ayon-core\client\ayon_core\lib\events.py", line 332, in process_event
//     callback(event)
//   File "c:\Work\REPO\ayon-maya\client\ayon_maya\plugins\create\create_maya_usd.py", line 30, in on_values_changed
//     if instance["creator_identifier"] != self.identifier:
// TypeError: 'NoneType' object is not subscriptable

Not failing but worth mentioning imho....

Testing notes:

  1. Create maya usd instance
  2. Trigger context attribute change
  3. No error should occur

@BigRoy BigRoy added the type: bug Something isn't working label Nov 5, 2024
@BigRoy BigRoy requested a review from LiborBatek November 5, 2024 09:01
@BigRoy BigRoy self-assigned this Nov 5, 2024
@BigRoy BigRoy merged commit 22b8ad5 into ynput:develop Nov 5, 2024
1 check passed
@BigRoy BigRoy deleted the bugfix/create_usd_error_on_context_attr_value_change branch November 5, 2024 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants