Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sure extract layout does not publish empty json #127

Merged
merged 3 commits into from
Sep 30, 2024
Merged

Make sure extract layout does not publish empty json #127

merged 3 commits into from
Sep 30, 2024

Conversation

moonyuet
Copy link
Member

Changelog Description

This PR is to make sure extract layout does not publish empty json

Additional info

Please try testing when groupLoadAssets option enabled

Testing notes:

  1. Create Layout
  2. Extract Layout

@moonyuet moonyuet requested a review from LiborBatek September 26, 2024 13:44
@moonyuet moonyuet marked this pull request as draft September 26, 2024 14:20
@moonyuet moonyuet closed this Sep 26, 2024
@moonyuet
Copy link
Member Author

the layout does not work because of other issue which is resolved by #104

@moonyuet moonyuet deleted the bugfix/extract_layout_result_empty_publish branch September 26, 2024 14:26
@moonyuet moonyuet restored the bugfix/extract_layout_result_empty_publish branch September 27, 2024 16:10
@moonyuet moonyuet reopened this Sep 27, 2024
LiborBatek
LiborBatek approved these changes Sep 30, 2024
View reviewed changes
Copy link
Member

@LiborBatek LiborBatek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All seems fine and working...I was able to produce succesful publish (checked that JSON been correct) and also tried to load layout product back into maya...all good!

Screenshot 2024-09-30 183504

once loaded back to maya:

Screenshot 2024-09-30 183908

@moonyuet moonyuet marked this pull request as ready for review September 30, 2024 18:37
@moonyuet moonyuet merged commit 4900172 into develop Sep 30, 2024
1 check passed
@moonyuet moonyuet deleted the bugfix/extract_layout_result_empty_publish branch September 30, 2024 18:37
@64qam 64qam added the type: enhancement Improvement of existing functionality or minor addition label Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LiborBatek LiborBatek LiborBatek approved these changes

Assignees

@LiborBatek LiborBatek

Labels
type: enhancement Improvement of existing functionality or minor addition
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@moonyuet @LiborBatek @64qam