Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix validate unit settings #118

Merged
merged 2 commits into from
Sep 23, 2024

Conversation

BigRoy
Copy link
Contributor

@BigRoy BigRoy commented Sep 19, 2024

Changelog Description

Fixes the validate units configuration when any setting for it was overridden.

Additional info

Apparently the labels and values were reversed.
Came up on discord here

Testing notes:

  1. Create addon
  2. Upload to bundle
  3. Set custom validate unit settings
  4. It should validate accordingly.

@BigRoy BigRoy added the type: bug Something isn't working label Sep 19, 2024
@BigRoy BigRoy requested a review from LiborBatek September 19, 2024 18:50
@BigRoy BigRoy self-assigned this Sep 19, 2024
Copy link
Member

@LiborBatek LiborBatek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Has been tested with few different settings (mm, centimeters, inches) and also matching / non matching maya scene units set...all works well.

Didnt spot any issues.

Screenshot 2024-09-20 135927

@BigRoy BigRoy merged commit fe4d553 into ynput:develop Sep 23, 2024
1 check passed
@BigRoy BigRoy deleted the bugfix/maya_validate_unit_settings branch September 23, 2024 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants