Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Look: Collect component assignment nodes as shapes #107

Merged
merged 3 commits into from
Sep 18, 2024

Conversation

BigRoy
Copy link
Contributor

@BigRoy BigRoy commented Sep 13, 2024

Changelog Description

Fix nodes with component assignments not being collected as the shape but the transform instead

Additional info

Fixes #106

Testing notes:

  1. Select all faces of a mesh.
  2. Assign a material
  3. Publish

(This is just to make an easy reproducable; however, similar issues may arise on merging or separating meshes or other maya construction history)

@BigRoy BigRoy added the type: bug Something isn't working label Sep 13, 2024
@BigRoy BigRoy requested a review from LiborBatek September 13, 2024 09:51
@BigRoy BigRoy self-assigned this Sep 13, 2024
@BigRoy BigRoy marked this pull request as ready for review September 14, 2024 11:27
Copy link
Member

@LiborBatek LiborBatek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have run it first in current state and it was failing:

Screenshot 2024-09-18 154024

But this PR resolve it and fully functional:

Screenshot 2024-09-18 155803

@BigRoy BigRoy merged commit 5c6cbb3 into ynput:develop Sep 18, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Look: Validate Look Sets fail if mesh has only face assignments
2 participants