Attributes: Min and max values #494
Merged
+119
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Innders
added
the
type: enhancement
|
Could you share a screenshot of the tooltip? Is the "Currently" value the the example value or the default value? And I assume this also changes/fixes the UX for the integer attributes? |
Integer is the same except those buttons are hidden because it will always be ≥ or ≤ |
Are you making smileys!? |
Innders
deleted the
479-Attributes-Make-greater-than-fields-more-human-friendly
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Instead of
gt, ge, lt, levalues useminandmax.When
type=floatgive the option to toggle>, ≥, <, ≤.Technical details
The returned attribute can not have both
geandgtat the same time (same forltandle).Additional context