Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Logger.mongo_process_id #981

Merged
merged 3 commits into from
Nov 1, 2024

Conversation

BigRoy
Copy link
Collaborator

@BigRoy BigRoy commented Oct 31, 2024

Changelog Description

Remove Logger.mongo_process_id

Additional info

Was once used a long time ago in ftrack services back in OpenPype era?

Testing notes:

  1. Logger should work
  2. Addons should still work (esp. ftrack)

@BigRoy BigRoy added the type: maintenance Changes to the code that don't affect product functionality (Technical debt, refactors etc.)) label Oct 31, 2024
@BigRoy BigRoy requested a review from iLLiCiTiT October 31, 2024 19:21
@BigRoy BigRoy self-assigned this Oct 31, 2024
@ynbot ynbot added the size/XS label Oct 31, 2024
@iLLiCiTiT
Copy link
Member

Was once used a long time ago in ftrack services back in OpenPype era?

Yes, Logger did store logs to mongo, and because ftrack does create subprocess this helped to store it under same process (and see in logs viewer the same in console).

@BigRoy BigRoy merged commit ed01619 into ynput:develop Nov 1, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XS type: maintenance Changes to the code that don't affect product functionality (Technical debt, refactors etc.))
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants