Fix single frame publishing for publish job on farm (to Deadline from e.g. Maya) #955
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog Description
Fix publishing of single frame render jobs.
Additional info
Why is this suddenly a new issue? It's due to this PR: #908
That actually fixed a long-standing bug... where a plug-in in Deadline would silently and secretly be fixing it, here: https://github.com/ynput/ayon-deadline/blob/368e2510dc3f8dc904168e51f9afa91c1428986c/client/ayon_deadline/plugins/publish/global/validate_expected_and_rendered_files.py#L74-L77
I couldn't fix this "on collect renders" for Maya - because that'd make it fail here where it still expects it to be a list:
ayon-core/client/ayon_core/pipeline/farm/tools.py
Lines 80 to 88 in e5fe964
This likely also fixes it for other hosts that use
instance.data["expectedFiles"]
with the value beinglist[dict[str, list[str]]]
(Basically the files per AOV, where the list of filenames islist[str]
but the integrator and other areas really want a singlestr
insteaf oflist[str]
if it's a single frame). One host I know that does so, is Houdini render submissions.Metadata json before this PR for a single frame:
After this PR:
Note the
files
key now being a single string instead of list of frames.Fixes ynput/ayon-maya#150
Testing notes:
(Without this PR it should fail on deadline publish job)
Tested: