Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maya: Remove remote publish logic #94

Merged
merged 2 commits into from
Feb 20, 2024

Conversation

iLLiCiTiT
Copy link
Member

Changelog Description

Removed remote maya publish plugins and scripts.

Additional info

The remote publish logic for Maya was probably copied from colorbleed fork, but it is missing important pieces to be able to work. The implementation did work in older versions of OpenPype, but now it would not work even in current version OpenPype. The plugins, as far as I can tell, are not used. The script path defined in submit plugin would not work in AYON at all, and the execution of python script would not work either as that would require ayon-launcher executable. The implementation of remote publish script did not implement any install of plugins of targets, nor did the function remote_publish in publish utils. The function was removed too as it might be misleading.

Testing notes:

  1. Nothing should change

@iLLiCiTiT iLLiCiTiT requested a review from antirotor February 19, 2024 17:11
@ynbot ynbot added size/S type: enhancement Improvement of existing functionality or minor addition host: Maya module: Deadline labels Feb 19, 2024
Copy link
Collaborator

@BigRoy BigRoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has come up before I believe - and yes, pretty sure it does not work in OpenPype and AYON.

Copy link
Member

@tokejepsen tokejepsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@iLLiCiTiT iLLiCiTiT merged commit ea3d6ab into develop Feb 20, 2024
10 checks passed
@iLLiCiTiT iLLiCiTiT deleted the enhancement/OP-8248_Remove-maya-remote-publish branch February 20, 2024 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
host: Maya module: Deadline size/S type: enhancement Improvement of existing functionality or minor addition
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants