Chore: Remove local settings function #83
Conversation
ynbot
added
size/XS
type: enhancement
| output.update(project_locals[site_name]) | ||
|
|
||
| return output | ||
| return {} |
There was a problem hiding this comment.
Should we have some warning here about the local settings not being available yet in AYON?
There was a problem hiding this comment.
There are TODOs all over the place, the warning would just scare artists about something they can't affect.
There was a problem hiding this comment.
Ahh, maybe a debug logging for developers then?
There was a problem hiding this comment.
I really don't think so. For last 3 years it was used on 1 place, and I don't think someone would start to use a function with Deprecated: in docstring and empty implementation.
|
@jakubjezek001 any code we can run for testing? |
I guess you meant me. Nothing technically changed, except of removed functions. |
|
Not sure if Todos are enough, I created issue for dirmap problem, #95. More issues should be created to follow them if necessary. |
I've already created tasks for that. |
iLLiCiTiT
deleted the
enhancement/OP-8271_Remove-local-settings-function
branch
Changelog Description
Removed
get_local_settingsfunction fromayon_core.settings.Additional info
Local settings are not implemented in AYON the same way as were in OpenPype. Some of the local settings from OpenPype are at this moment not available in AYON at all, and other ones are stored per addon. It is not possible to easily receive all the values as it was in OpenPype, at least not now, and we have to make full replacement of them in future.
Testing notes:
There is no visible change.