USD plugin: Don't crash plugin file because of missing dependency #796
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ynbot
added
type: enhancement
BigRoy
approved these changes
Aug 28, 2024
There was a problem hiding this comment.
I started fiddling around with other ways that would completely "deregister" the plug-ins etc. and issue a one shot warning using warnings package... but it just felt less nice for artists because they'd still get a warning to the console.
This is much more hidden away until it hits a production case where it should have been working - so fine with me.
Worked in Maya 2024 with USD exports, and tray publisher + maya did indeed ignore it as crashed plug-ins.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog Description
USD publish plugin files do not crash on missing dependency.
Additional info
Added validator to check missing dependencies.
This is first shot, any modifications welcommed, the point is that the file should not crash.
Testing notes:
extract_usd_layer_contributions.py).