-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Core: Use AYON settings #74
Merged
iLLiCiTiT
merged 19 commits into
develop
from
enhancement/OP-8206_Core-use-AYON-settings
Feb 19, 2024
Merged
Core: Use AYON settings #74
iLLiCiTiT
merged 19 commits into
develop
from
enhancement/OP-8206_Core-use-AYON-settings
Feb 19, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ynbot
added
size/S
type: enhancement
Improvement of existing functionality or minor addition
host: After Effects
host: Nuke
labels
Feb 15, 2024
iLLiCiTiT
requested review from
m-u-r-p-h-y,
simonebarbieri,
kalisp,
MustafaJafar and
jakubjezek001
February 15, 2024 18:07
BigRoy
reviewed
Feb 15, 2024
tokejepsen
requested changes
Feb 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Traceback (most recent call last):
File "C:\Users\tokejepsen\AppData\Local\Ynput\AYON\dependency_packages\ayon_2402141620_windows.zip\dependencies\pyblish\plugin.py", line 527, in __explicit_process
runner(*args)
File "C:\Users\tokejepsen\ayon-core\client\ayon_core\plugins\publish\extract_burnin.py", line 89, in process
self.main_process(instance)
File "C:\Users\tokejepsen\ayon-core\client\ayon_core\plugins\publish\extract_burnin.py", line 197, in main_process
burnins_per_repres = self._get_burnins_per_representations(
File "C:\Users\tokejepsen\ayon-core\client\ayon_core\plugins\publish\extract_burnin.py", line 117, in _get_burnins_per_representations
"burnin_defs.keys(): {}".format(burnin_defs.keys())
AttributeError: 'list' object has no attribute 'keys'
jakubjezek001
approved these changes
Feb 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog Description
Core project settings conversion was removed.
Additional info
Replace
"global"
with"core"
and moved conversions into the code.Testing notes:
Things that should be validated.