Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Core: Use AYON settings #74

Merged
merged 19 commits into from
Feb 19, 2024

Conversation

iLLiCiTiT
Copy link
Member

@iLLiCiTiT iLLiCiTiT commented Feb 15, 2024

Changelog Description

Core project settings conversion was removed.

Additional info

Replace "global" with "core" and moved conversions into the code.

Testing notes:

Things that should be validated.

  • Subset name is calculated correctly.
  • ExtractReview works.
  • ExtractBurnin works (different background and font colors).
  • ExtractThumbnail works (agains different colors etc.).

Copy link
Member

@tokejepsen tokejepsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Traceback (most recent call last):
  File "C:\Users\tokejepsen\AppData\Local\Ynput\AYON\dependency_packages\ayon_2402141620_windows.zip\dependencies\pyblish\plugin.py", line 527, in __explicit_process
    runner(*args)
  File "C:\Users\tokejepsen\ayon-core\client\ayon_core\plugins\publish\extract_burnin.py", line 89, in process
    self.main_process(instance)
  File "C:\Users\tokejepsen\ayon-core\client\ayon_core\plugins\publish\extract_burnin.py", line 197, in main_process
    burnins_per_repres = self._get_burnins_per_representations(
  File "C:\Users\tokejepsen\ayon-core\client\ayon_core\plugins\publish\extract_burnin.py", line 117, in _get_burnins_per_representations
    "burnin_defs.keys(): {}".format(burnin_defs.keys())
AttributeError: 'list' object has no attribute 'keys'

@iLLiCiTiT iLLiCiTiT requested a review from tokejepsen February 19, 2024 13:22
Copy link
Member

@jakubjezek001 jakubjezek001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@iLLiCiTiT iLLiCiTiT merged commit 8f8358e into develop Feb 19, 2024
5 checks passed
@iLLiCiTiT iLLiCiTiT deleted the enhancement/OP-8206_Core-use-AYON-settings branch February 19, 2024 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
host: Nuke size/S type: enhancement Improvement of existing functionality or minor addition
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants