Scene Inventory: remove unused container attribute #643
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
name isn't used anywhere but it is hard required, causing crashes in hosts that are not having it. Also adding broad try/except to catch any invalid containers so they won't crash the whole list
iLLiCiTiT
reviewed
Jun 12, 2024
iLLiCiTiT
reviewed
Jun 12, 2024
Co-authored-by: Jakub Trllo <[email protected]>
iLLiCiTiT
approved these changes
Jun 12, 2024
iLLiCiTiT
reviewed
Jun 12, 2024
| containers_by_id[item.item_id] = container | ||
| container_items_by_id[item.item_id] = item | ||
| container_items.append(item) | ||
|
|
||
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
nameisn't used anywhere but it is hard required, causing crashes in hosts that are not having it. Also adding broad try/except to catch any invalid containers so they won't crash the whole list.Testing
Scene inventory should list loaded stuff even without
name- currently this affects Unreal as far as I know.