-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chore: Editorial does not use asset naming #592
Chore: Editorial does not use asset naming #592
Conversation
@@ -676,6 +676,8 @@ def _get_base_instance_data( | |||
"shotName": shot_name, | |||
"variant": variant_name, | |||
"task": None, | |||
"newHierarchyIntegration": True, | |||
# Backwards compatible | |||
"newAssetPublishing": True, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we now start removing this older data key to ensure the new one does what we want it to do?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can have new traypublisher addon and old ayon-core addon...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we add a remove backwards compatibility by version x.y.z
label to the comment so we know when to remove it in the future? Or do we prepare an issue now to remind us in say 3 months?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you not make use of the package ayon_required_addons
to force a minimum version?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we add a remove backwards compatibility by version x.y.z label to the comment so we know when to remove it in the future? Or do we prepare an issue now to remind us in say 3 months?
At this moment specific version is too "wild" guess. But I guess we can add at least date when it "started" to be deprecated?
can you not make use of the package ayon_required_addons to force a minimum version?
You can, but core cannot (or should not). And at this moment we don't know about all unofficial addons using this.
Changelog Description
Use key
"newHierarchyIntegration"
instead of"newAssetPublishing"
.Additional info
The value stored under the key defines that a new folder and tasks may be created. In that case folder entity and task entity may not be available.
Testing notes: