Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Loader tools: Fix sorting of versions in comboboxes #559

Merged
merged 2 commits into from
Jun 4, 2024
Merged

Loader tools: Fix sorting of versions in comboboxes #559

merged 2 commits into from
Jun 4, 2024

Conversation

iLLiCiTiT
Copy link
Member

Changelog Description

Hero versions are not at correct place in versions combobox.

Additional info

Paragraphs of text giving context of additional technical information or code examples.

Screenshots

Before this PR
image

With this PR
image

Testing notes:

  1. Open loader tool (from tray or in host).
  2. Try to look at versions ordering on product which has hero version.
  3. The hero version should be after it's standard version.

@ynbot ynbot added type: bug Something isn't working size/XS labels May 28, 2024
@64qam 64qam requested a review from MilaKudr May 28, 2024 11:51
@iLLiCiTiT iLLiCiTiT merged commit 9a63d24 into develop Jun 4, 2024
1 check passed
@iLLiCiTiT iLLiCiTiT deleted the bugfix/loader-versions-sorting branch June 4, 2024 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@64qam 64qam 64qam approved these changes

@antirotor antirotor Awaiting requested review from antirotor

@jakubjezek001 jakubjezek001 Awaiting requested review from jakubjezek001

@kalisp kalisp Awaiting requested review from kalisp

@MilaKudr MilaKudr Awaiting requested review from MilaKudr

Assignees

@kalisp kalisp

Labels
size/XS type: bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@iLLiCiTiT @64qam @kalisp @ynbot