-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Maya: Workfile Increment in one go #545
Maya: Workfile Increment in one go #545
Conversation
Task linked: AY-5538 workfile increment in one go |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The tool does what it should also tested with custom _suffix
present in the filename and all working fine.
There might be few questions still.
First if the tool should be named as it is atm
or changed to someting like Workfile Increment Version
or similar @antirotor @BigRoy opinions on that?
And second if it should be somehow treated in relation to native maya CTRL+ALT+S
Incremental save action...as now it is not working with conjunction with it and produce odd results on the active workfile version.... (by appending another version like myworkfilename_v0010.001
)
Again something to consider imho.
I agree that it looks odd in the list where it is. Note that we've had this in Maya all this time already but in our custom scripts menu. For sake of reference, here is a screenshot: What is nice about that one is that it's very close to the top since it's such a frequently clicked button - and preferably also NOT misclicked with "Set frame range" in the list where it is now. As such I'm wondering whether it's worth thinking about moving it directly below the greyed out current context entry as just "Version up" or "Version up workfile".
It would be nice to have it be able to pick that up - yet at the same time we do want to keep it abstractly working also with other DCCs or with custom comments in the names like Another benefit is that with that logic it would also be capable of generating the first version name :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works as expected and now the tool sits in Custom Menu
.
Still would like to hear opinions on that... @antirotor @m-u-r-p-h-y
But can be merged as is imho.
If we're going for custom menu - can we move it to the top by default? If we're not, then I'd still want to argue for moving it to the top of the AYON menu (which is what I initially meant). |
My opinion is not to have it in custom menu - where we shouldn't add core ayon behavior and leave it for studio customizations and maybe some optional or very specialized scripts. And that would mean having it as high as possible in the main menu. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed - with that label on the setting I also wouldn't expect that to influence the menu entry. We should really label it something like "Add 'Version Up Workfile' to AYON menu" or something alike, and of course place it in a sensible place. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With maya client code separated I believe this PR should also bump the maya addon version.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Didn't test - code overall looks good to me.
I did have one comment on title in settings - there's also still an open comment by @iLLiCiTiT to revert ayon core version change.
Also, this comment should still be considered but for a separate issue.
… that workfile is not overwritten
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested, it works nice. Thanks
@antirotor could you test this edge case? |
Co-authored-by: Jakub Trllo <[email protected]>
Changelog Description
This PR is to add the option to increment and save workfile in Maya.
Additional info
Testing notes:
Enable the plugin in
ayon+settings://core/tools/Workfiles/ayon_menu/version_up_workfile
Launch Maya
Go to AYON
Click
Version up Workfile