Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Launcher tool: Fix view update #528

Merged
merged 2 commits into from
May 21, 2024

Conversation

iLLiCiTiT
Copy link
Member

@iLLiCiTiT iLLiCiTiT commented May 20, 2024

Changelog Description

Call update on viewport instead on view.

Additional info

Method update on view does update single index which should be passed in, but it is not. The bug was discovered with PySide6.

Traceback

Traceback (most recent call last):
  File ".\client\ayon_core\tools\launcher\ui\actions_widget.py", line 362, in _on_model_refresh
    self._view.update()
  TypeError: QListView.update() takes exactly one argument (0 given)

Testing notes:

You would have to use macOs or force using PySide6 in AYON launcher (for other platforms).

  1. Start ayon launcher with console.
  2. In tray open Launcher tool.
  3. Select project and change context few times.
  4. The traceback should not be raised.
  • With PySide2 launcher tool works as expected too.

Copy link
Member

@kalisp kalisp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with forced PySide6 on Windows, fixes the issue.

@kalisp kalisp assigned iLLiCiTiT and unassigned kalisp May 21, 2024
@iLLiCiTiT iLLiCiTiT merged commit aa1ac97 into develop May 21, 2024
1 check passed
@iLLiCiTiT iLLiCiTiT deleted the bugfix/launcher-update-view-properly branch May 21, 2024 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XS type: bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants