Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Push to Project: Fix task lowering #527

Merged
merged 2 commits into from
May 20, 2024

Conversation

iLLiCiTiT
Copy link
Member

Changelog Description

Lower task name when is used, and not when it can be None.

Additional information

Quick fix without knowing full context -> missing test notes @MustafaJafar fill if you can.

@iLLiCiTiT iLLiCiTiT requested a review from MustafaJafar May 20, 2024 10:22
@ynbot ynbot added size/XS type: bug Something isn't working labels May 20, 2024
Copy link
Contributor

@MustafaJafar MustafaJafar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

when pushing different product types it works as expected.
Animation_64

when pushing work files I get an error.
Animation_65

Error:
image

@iLLiCiTiT
Copy link
Member Author

Error:

That's something I can't fix as your settings of workfile product name template require task.

@MustafaJafar
Copy link
Contributor

That's something I can't fix as your settings of workfile product name template require task.

Oh, thanks!
The default workfile product name profile includes the task name. And, the error has gone when {Task[name]} is removed.

ayon+settings://core/tools/creator/product_name_profiles

Copy link
Contributor

@MustafaJafar MustafaJafar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works on my side,
However, I had to tweak the default settings to push the workfile to the library project.

ayon+settings://core/tools/creator/product_name_profiles

Removed {Task[name]}
image

@iLLiCiTiT iLLiCiTiT merged commit 02759f5 into develop May 20, 2024
1 check passed
@iLLiCiTiT iLLiCiTiT deleted the bugfix/push-to-project-task-name-lowering branch May 20, 2024 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XS type: bug Something isn't working
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants