Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Colorspace: Fix Anatomy object initialization #526

Merged
merged 2 commits into from
May 20, 2024
Merged

Colorspace: Fix Anatomy object initialization #526

merged 2 commits into from
May 20, 2024

Conversation

iLLiCiTiT
Copy link
Member

@iLLiCiTiT iLLiCiTiT commented May 20, 2024 •
edited
Loading

Changelog Description

Use kwargs to pass project entity to Anatomy initialization.

Additional info

Project entity was passed in as site name instead of project entity.

Testing notes:

  • Make sure you have core with new imageio color settings (or create package from this PR and upload to server to be sure).
  1. Enable colormanagement in core addon.
  2. Launch host of your choice (should have ability to run python scripts)
  3. Run this
from ayon_core.pipeline.colorspace import get_current_context_imageio_config_preset

get_current_context_imageio_config_preset()

It should not crash.

@ynbot ynbot added size/XS type: bug Something isn't working labels May 20, 2024
MustafaJafar
MustafaJafar approved these changes May 20, 2024
View reviewed changes
Copy link
Contributor

@MustafaJafar MustafaJafar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works on my side.

@iLLiCiTiT iLLiCiTiT merged commit 009b211 into develop May 20, 2024
1 check passed
@iLLiCiTiT iLLiCiTiT deleted the bugfix/colorspace-anatomy-init branch May 20, 2024 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MustafaJafar MustafaJafar MustafaJafar approved these changes

@kalisp kalisp Awaiting requested review from kalisp

@jakubjezek001 jakubjezek001 Awaiting requested review from jakubjezek001

@moonyuet moonyuet Awaiting requested review from moonyuet

Assignees

@jakubjezek001 jakubjezek001

Labels
size/XS type: bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@iLLiCiTiT @MustafaJafar @jakubjezek001 @ynbot