Chore: Validate Content plugin settings #525
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Task linked: AY-5419 Validate Content plugin settings |
ynbot
added
host: After Effects
host: Maya
host: Nuke
size/S
type: enhancement
MustafaJafar
approved these changes
May 20, 2024
iLLiCiTiT
deleted the
enhancement/AY-5419_Validate-Content-plugin-settings
branch
BigRoy
reviewed
May 20, 2024
| @@ -770,6 +797,10 @@ class PublishPuginsModel(BaseSettingsModel): | |||
| default_factory=ValidateBaseModel, | |||
| title="Validate Version" | |||
| ) | |||
| ValidateContainers: ValidateContainersModel = SettingsField( | |||
| default_factory=ValidateContainersModel, | |||
| title="Validate Containers" | |||
There was a problem hiding this comment.
Should we update the title to Validate Outdated Containers so it matches the label on the plug-in itself?
With just Validate Containers it leaves me a bit guessing what it validates about the containers?
There was a problem hiding this comment.
Eh, why you wrote it after merge, now I have to create new PR...
There was a problem hiding this comment.
Sorry, day off today - saw it a bit too late.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog Description
Added profile based settings for Validate Content publish plugin.
Additional info
The settings will change behavior of the plugin based on host name. The plugin is disabled if host does not support load functionality, or there are no profiles. Removed settings of the plugin from other hosts.
We should do this for the move of hosts. The first encounter happened in #516 .
Testing notes: