-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Houdini: add model family (initial support) #486
Houdini: add model family (initial support) #486
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, the PR needs small addition to work. I added that info to additional info in the PR description. I can't decide what solution is favored:
Also, this comment #486 (comment) should be considered because it affects the execution flow of publishing models. |
If you talk about the solution two, you can consider the code below for the model creator. You just need to make sure the identifier is neither class ExtractModelABC(ExtractAlembic):
"""Extract model as ABC."""
identifier = "io.openpype.creators.houdini.model"
label = "Extract Alembic (Model)"
families = ["model"]
# Driven by settings
optional = True For solution one, I slightly look at how the creator built in the maya host, guess the published families somehow need to be decided during creating the instance. not sure if we can do some tricks on settings(some multiselection one) to let user decide which families type they want to publish?(not sure if it is a good idea.) |
suppose we are allowed to publish multiple representations per product.
For development, Personally, I'd prefer to use I think we should move this discussion to a dedicated place. |
In this 475d1db I've added @moonyuet's suggestion about using a collector to add I didn't update extractor because it already runs on ayon-core/client/ayon_core/hosts/houdini/plugins/publish/extract_alembic.py Lines 11 to 16 in d51e7a9
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
client/ayon_core/hosts/houdini/plugins/publish/validate_mesh_is_static.py
Show resolved
Hide resolved
…ps://github.com/ynput/ayon-core into enhancement/AY-4085_Houdini-adding-model-family
client/ayon_core/hosts/houdini/plugins/publish/validate_export_is_a_single_frame.py
Outdated
Show resolved
Hide resolved
Co-authored-by: Jakub Trllo <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did a model roundtrip between Houdini and Maya without any issue
Changelog Description
Adding model family to Houdini.
The main purpose to support Maya (load/publish model from maya to/from houdini).
Additional info
Currently, The new creator plugin is almost the same as 'create_pointcache.py'
But renaming the product type to 'model'.
It's considered to support multiple representations in the future.
Additional info 2
This PR uses
collect_instances_type.py
toabc
family to publish families ofModel
instances.Testing notes: