Applications: Disable applications addon if does not have settings available #360
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BigRoy
reviewed
Apr 3, 2024
| @@ -11,6 +11,10 @@ | |||
| class ApplicationsAddon(AYONAddon, IPluginPaths): | |||
| name = "applications" | |||
|
|
|||
| def initialize(self, settings): | |||
| # TODO remove when addon is removed from ayon-core | |||
| self.enabled = self.name in settings | |||
There was a problem hiding this comment.
How come this is needed? Is it because addons present in ayon core are currently always loaded no matter what?
There was a problem hiding this comment.
Yes.
EDITED:
They are skipped if already have different source.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog Description
Disable applications addon if does not have available settings (addon is disabled on server).
Additional info
The client addon would crash if server would be disabled.