-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Applications: Live attributes update #350
Applications: Live attributes update #350
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding new variants with live updating works, but default variants (both for tools and applications) are present in enums even if i remove them and replace with others. i purged all previous versions of the application addon as well as all settings, but old variants are still there.
Also. Could you please add:
from ayon_server.entities.core import attribute_library
await attribute_library.load()
to the end of update_enums? it is not required for now, but in a future release (soon) this will invalidate attribute cache in redis, which is going to be needed for horizontal scaling of the server. At this point, it won't hurt doing it, so it is just for forwards compatibility.
Did you remove them in both the production settings AND the staging settings? |
As Roy mentioned, did you change staging applications too?
Could you add function from ayon_server.entities.core import attribute_library
await attribute_library.load() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's out of scope of this PR and my competence. It works ok for me, but I don't have opened 2 windows which might be the reason? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you are right. it was becasue of two windows opened (for the screenshot)
in single window it works as expected!
Yep. But it's better than restarting the server. Also we might be able to do that without page reload, but that's a frontend/backend issue (planned). We need to notify connected clients that they should invalidate their cached attribute list. |
Changelog Description
Update attribute values on settings save.
Additional info
This helps to update the attribute live on settings change. It does work from this version up. The update does not require restart of server, but the live attributes update is available from server version 1.0.7 .
Testing notes: