-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Houdini local render support #328
Houdini local render support #328
Conversation
client/ayon_core/hosts/houdini/plugins/create/create_mantra_rop.py
Outdated
Show resolved
Hide resolved
client/ayon_core/hosts/houdini/plugins/publish/validate_split_render_is_disabled.py
Outdated
Show resolved
Hide resolved
client/ayon_core/modules/deadline/plugins/publish/collect_pools.py
Outdated
Show resolved
Hide resolved
…ccording to render target value
For reference here's how it looks like |
client/ayon_core/hosts/houdini/plugins/publish/collect_local_render_instances.py
Outdated
Show resolved
Hide resolved
client/ayon_core/hosts/houdini/plugins/publish/extract_local_render.py
Outdated
Show resolved
Hide resolved
Co-authored-by: Kayla Man <[email protected]>
…to adjust parameters accordingly
So far this PR works but I have some considerations from my point of view:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested with AOV renders in Mantra. Looks good. Maybe there should be some reminders that each renderer has different AOV suffix in terms of filenames, and we won't misuse the $AOV
into the renderers other than into Redshift.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested both local and farm rendering with Redshift and it works. I am still not convinced with farm_split
name as it's not very descriptive and then there is splitRender
used. But I have no idea how to change it :)
I couldn't pick better names. |
…/github.com/ynput/ayon-core into enhancement/AY-1009_Houdini-Local-Rendering
Should we merge this ticket or we still need to work on something else? @MustafaJafar @antirotor |
Can we also have a feature to publish through the Solaris tree renders? Currently, the karma rop is working well. but, all the people use only the solaris tree as we have more control there on stage. Please let me know your thoughts on this. |
Are you saying you would like to publish or submit using the USD Render ROP inside For what it's worth, I believe #295 implements supporting USD Render ROP for Deadline submissions using Husk standalone for rendering - however, I think it's still aimed at working in I'm working on some more houdini-wide efforts to support more generalized publishing and submissions that is a more global 'rethink' of how things work in Houdini. This may affect also your question here over time. Could you elaborate on your exact use case? |
Changelog Description
This PR adds support for local rendering in Houdini and marking render as reviewable.
Additional Info: How it works
The logic of this PR is based on re-using the collected data for each render instance to perform local rendering.
this happens by remapping the collected data
expectedFiles
where I use them to create a dedicated instance for each AOV in theexpectedFiles
while keeping the original instance empty.I couldn't remove the original instance while this process because it holds the debug data.
Compute
expectedFiles
which is a dictionary of AOVs and their files.if farm disabled append
render.local.hou
to familiescreate instance for each AOV in expected files and add essential data and its representation data
if farm disabled, if
skip_render
disabled, render the nodeTesting notes:
Submitting to Farm
Submitting to Farm