Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Maya: Optimize get_related_sets #324

Merged
merged 4 commits into from
Apr 4, 2024
Merged

Maya: Optimize get_related_sets #324

merged 4 commits into from
Apr 4, 2024

Conversation

BigRoy
Copy link
Collaborator

@BigRoy BigRoy commented Mar 29, 2024

Changelog Description

Optimize get_related_sets by opting-out earlier if no valid sets to perform less maya calls

Additional info

This is a bit of a micro-optimization. Just happened to have this in our OpenPype codebase.

Testing notes:

  1. Maya look collecting and publishing should still work

@BigRoy
Optimize get_related_sets
f17170d 
Opt-out earlier if no valid sets to perform less maya calls
@ynbot ynbot added size/XS type: enhancement Improvement of existing functionality or minor addition host: Maya labels Mar 29, 2024
@BigRoy BigRoy requested review from tokejepsen and iLLiCiTiT March 29, 2024 13:43
@MustafaJafar MustafaJafar added the community Issues and PRs coming from the community members label Apr 1, 2024
tokejepsen
tokejepsen approved these changes Apr 2, 2024
View reviewed changes
Copy link
Member

@tokejepsen tokejepsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested successfully in Maya 2023.

tokejepsen
tokejepsen approved these changes Apr 4, 2024
View reviewed changes
Copy link
Member

@tokejepsen tokejepsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still works.

@tokejepsen tokejepsen requested a review from iLLiCiTiT April 4, 2024 07:13
@iLLiCiTiT iLLiCiTiT merged commit 9ee2287 into ynput:develop Apr 4, 2024
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tokejepsen tokejepsen tokejepsen approved these changes

@iLLiCiTiT iLLiCiTiT Awaiting requested review from iLLiCiTiT

Assignees

@iLLiCiTiT iLLiCiTiT

Labels
community Issues and PRs coming from the community members host: Maya size/XS type: enhancement Improvement of existing functionality or minor addition
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@BigRoy @tokejepsen @iLLiCiTiT @MustafaJafar @ynbot