Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maya: Set scene frame range - apply playback options in one call #323

Merged

Conversation

BigRoy
Copy link
Collaborator

@BigRoy BigRoy commented Mar 29, 2024

Changelog Description

Don't set time slider values one by one, but set all at once.

Additional info

Less maya calls is always good.

This really shouldn't break anything. :)

Testing notes:

  1. Updating scene frame range should work. (e.g. reset frame range) or by the 'fix' in the prompt on scene save if your scene is wrong frame range.

Copy link
Member

@m-u-r-p-h-y m-u-r-p-h-y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should not we already take the values from the task, not the shot? It was true for OP but in Ayon we already have task level attributes.

Also can I ask for improving the info message we print to the script editor? We only inform about the fps change, it would be great to include all attributes we touch (frameStart, frameEnd)

image

Copy link
Contributor

@MustafaJafar MustafaJafar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works on my side.

@MustafaJafar
Copy link
Contributor

MustafaJafar commented Apr 1, 2024

Should not we already take the values from the task, not the shot? It was true for OP but in Ayon we already have task level attributes.

Yeah, I traced that and found the problem which is not related to this PR. I made a PR #338

@MustafaJafar MustafaJafar requested a review from m-u-r-p-h-y April 1, 2024 12:20
@MustafaJafar MustafaJafar added the community Issues and PRs coming from the community members label Apr 1, 2024
Copy link
Member

@tokejepsen tokejepsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you update the title and description as this only affects the time range and not the FPS?

@BigRoy BigRoy changed the title Maya: Set scene fps - apply playback options in one call Maya: Set scene frame range - apply playback options in one call Apr 2, 2024
@BigRoy
Copy link
Collaborator Author

BigRoy commented Apr 2, 2024

Could you update the title and description as this only affects the time range and not the FPS?

Well spotted. Thanks! Done.

Should not we already take the values from the task, not the shot? It was true for OP but in Ayon we already have task level attributes.

Yeah, I traced that and found the problem which is not related to this PR. I made a PR #338

Nice work and good thinking!

@tokejepsen tokejepsen dismissed m-u-r-p-h-y’s stale review April 4, 2024 07:08

Separate to this PR

@tokejepsen tokejepsen merged commit a73689b into ynput:develop Apr 4, 2024
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community Issues and PRs coming from the community members host: Maya size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants