-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Maya: Set scene frame range - apply playback options in one call #323
Maya: Set scene frame range - apply playback options in one call #323
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should not we already take the values from the task, not the shot? It was true for OP but in Ayon we already have task level attributes.
Also can I ask for improving the info message we print to the script editor? We only inform about the fps change, it would be great to include all attributes we touch (frameStart, frameEnd)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It works on my side.
Yeah, I traced that and found the problem which is not related to this PR. I made a PR #338 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you update the title and description as this only affects the time range and not the FPS?
Well spotted. Thanks! Done.
Nice work and good thinking! |
Changelog Description
Don't set time slider values one by one, but set all at once.
Additional info
Less maya calls is always good.
This really shouldn't break anything. :)
Testing notes: