Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract Review: Fix typos + remove unused variable #312

Merged
merged 5 commits into from
Apr 2, 2024

Conversation

BigRoy
Copy link
Collaborator

@BigRoy BigRoy commented Mar 28, 2024

Changelog Description

Cleanup code: remove unused variable pixel_aspect and fix typos

Additional info

n/a

Testing notes:

  1. Extract review should work.

@ynbot ynbot added the size/XS label Mar 28, 2024
@MustafaJafar MustafaJafar added the community Issues and PRs coming from the community members label Apr 1, 2024
Copy link
Contributor

@MustafaJafar MustafaJafar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code-spell has reviewed your PR.

PS E:\Ynput\ayon-core> ./.poetry/bin/poetry run codespell client/ayon_core/plugins/publish/extract_review.py
client/ayon_core/plugins/publish/extract_review.py:622: ouput ==> output
client/ayon_core/plugins/publish/extract_review.py:958: witht ==> with
client/ayon_core/plugins/publish/extract_review.py:970: tempalte ==> template
client/ayon_core/plugins/publish/extract_review.py:1000: representaion ==> representation
client/ayon_core/plugins/publish/extract_review.py:1228: reformated ==> reformatted
client/ayon_core/plugins/publish/extract_review.py:1548: Containg ==> Containing
client/ayon_core/plugins/publish/extract_review.py:1862: beggining ==> beginning
7

@BigRoy
Copy link
Collaborator Author

BigRoy commented Apr 2, 2024

Code-spell has reviewed your PR.

PS E:\Ynput\ayon-core> ./.poetry/bin/poetry run codespell client/ayon_core/plugins/publish/extract_review.py
client/ayon_core/plugins/publish/extract_review.py:622: ouput ==> output
client/ayon_core/plugins/publish/extract_review.py:958: witht ==> with
client/ayon_core/plugins/publish/extract_review.py:970: tempalte ==> template
client/ayon_core/plugins/publish/extract_review.py:1000: representaion ==> representation
client/ayon_core/plugins/publish/extract_review.py:1228: reformated ==> reformatted
client/ayon_core/plugins/publish/extract_review.py:1548: Containg ==> Containing
client/ayon_core/plugins/publish/extract_review.py:1862: beggining ==> beginning
7

Thanks, fixed with 413f304

Except reformated - skipped that in favor of this PR: #285

@iLLiCiTiT iLLiCiTiT merged commit 69e08a7 into ynput:develop Apr 2, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community Issues and PRs coming from the community members size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants