-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Launcher: Use selection object for action #306
Conversation
project_entity=None, | ||
folder_entity=None, | ||
task_entity=None |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you point me to where we're actually setting these from the launcher? I can't seem to find that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nowhere.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In that case - we shouldn't expose it as if it'll be available? :) Or will you be adding commits to fix it? :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah wait, I only now see that it queries it whenever you access it. Nevermind. I'm blind.
Should maybe stab myself in the eye with a fork to wake me up.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not? It might be used for testing.
Co-authored-by: Roy Nieterau <[email protected]>
Confirmed.
This plugin doesn't seem to get listed for me. Using the
Even when I have a folder and task selected. By the way, if for whatever reason you iterate the object I get this: for key in session:
File "E:\dev\ayon-core\client\ayon_core\pipeline\actions.py", line 71, in __getitem__
raise KeyError(f"Key: {key} not found") Which seemed confusing. The old |
Should be fixed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My custom actions now show up and launch ok. 👍
Changelog Description
Prepared selection object that helps to handle selection in Launcher actions.
Additional info
The object should backwards compatible for unconverted actions.
Testing notes: